Add Echo360 EchoVideos as a provider #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2023
otacke
reviewed
Feb 14, 2024
| }, | ||
| { | ||
| name: 'Echo360', | ||
| regexp: /^[^\/]+:\/\/(echo360[^\/]+)\/media\/([^\/]+)\/h5p.*$/i, |
There was a problem hiding this comment.
Just a note: If Echo360 requires to have an extra link to serve videos for H5P in addition to the public link that one gets when intending to share the video, and that's not too confusing for Echo360 users, that regex seems fine.
There was a problem hiding this comment.
Thanks - yes Echo360 requires a separate route which triggers some minor layout changes and feature changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Echo360 (https://echo360.com/) we have been asked by our customers to allow videos captured in our EchoVideo platform to be able to be included in H5P content. We have added these features in our test environment and they will be released generally at the end of the year.
For this to work in the same way as other supported video platforms it will require changes to both this repository as well as the H5P Video library. Our changes are modelled after the other video platforms.