Bug in enable_save_content_state

[Jarvil]

Hello,

I'm using mod_hvp 1.4 (2017060600) & Moodle 3.3.1+ (Build: 20170727).

When I set "Save content state mod_hvp | enable_save_content_state" to "on" and
edit f.ex. course presentation and add an image to it and press "save and display" I get an error message;

"Data reset"

"This content has changed since you last used it.

You'll be starting over."

This happens in other H5P-libraries too so the seems to be an bug in that setting because it suggests that everytime you edit something.

[Jarvil]

Tested this also in Moodle 3.1.6 (Build: 20170508) and I get the same error.

[timothyylim]

Hi @Jarvil,

This is by design. If the content changes the states saved might be invalid. For instance if you were on slide 6 and slide 6(or before 6) is deleted, then your state doesn't make any sense anymore.

It might be that a checkbox is added so that the author may choose not to delete the states when editing content.

Does this help?

[Jarvil]

Hello,

Have you tried it yourself in the real life? It is not really useful when it states "data reset start from beginning" even if you don't edit anything or just change a one thing.

[timothyylim]

Hi @Jarvil, what do you mean? It shouldn't show unless you have changed anything, if you've changed one thing I think it still makes sense for a warning to be shown.

[Jarvil]

Hello,

The message is displayed even if I don't edit anything. When I just open the activity and save and return to the course.

[timothyylim]

Ok, that definitely sounds like a bug. I've created a ticket for it to be reviewed in the next release:

https://h5ptechnology.atlassian.net/browse/HFP-1383

Thanks for reporting the bug!

[falcon-git]

It is not a bug, it is by design. I've updated the Jira issue.

[falcon-git]

I can see why the current behavior is problematic in many cases. The organization that designed and funded this feature wanted the current behavior, and it seems most H5P users don't have "save content state" enabled. We haven't been able to prioritize improving this behavior yet, unfortunately.