Fix: Author comments can contain linebreaks #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h5p. This pull request is open for more than one year now. Can you please check and merge the improvement? |
|
@JsBergbau I guess given that https://github.com/h5p/h5p-php-library/pull/109/files fixed the issue as well (including the log and the license extras with the same problem), you could simply close your pull request. |
|
Thanks for your fast answer. Since #109 was merged it is indeed not needed anymore. However interesting that your Pull request was merged after two month, whereas this pull request was almost 11 month earlier and didn't get merged. |
|
@JsBergbau I don't know how pull requests are handled. If I remember correctly, I may have hinted to mine on some other channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author comments can contain line breaks, fixing that validation failed so far.
For more details see #96