Changed hiding of slides by using visibility instead of display. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As future use cases might include the use of MathJax, one wants to avoid the use of `display: none` to hide elements. By using `visibility: hidden` in combination with a offscreen position almost the same effect is achieved.
|
Hi @sdcloudt ! Thanks for your contribution! We're giving our own solution for LaTeX support the finishing touches right now, and it doesn't require the changes that you're proposing. It will feature several options to (re)render divs as needed (with MathJax or KaTeX). Also, it will not require to change any content types. What do you think? Would that solve your issue as well? Cheers, |
|
Hi @otacke
Unfortunately will that not be sufficient to solve my specific problem. We have an existing questioning system which we currently use. Unfortunately I am not in the position to change this system. Therefore I embed this question containing MathJax within an iFrame. That iFrame is inserted as content of an h5p-question. The rendering of that MathJax is done by the existing system, so I cannot modify this rendering nor replace it by an h5p latex support.
I like the fact that LaTeX support is coming, though it might not solve my current problem it definitely has many use cases!
Do you have any suggestions for improvement of my changes?
Cheers,Stefan
|
|
Hi Stefan! I don't think there's something wrong with your code, and I have seen moving elements out of the visual area instead of not displaying them before, but mostly for transitioning effects. Maybe @fnoks could share his thoughts on this issue as well? |
|
Bump @fnoks ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the h5p community there is interest in using MathJax in h5p elements: https://h5p.org/comment/2934#comment-2934
If one would create a new Question type which uses MathJax (which I have done but unfortenately I cannot share it) the use of jQuery's
hideandshowcauses MathJax to render wrong on hidden questions. This is becausehideandshowset and unset the cssdisplayproperty tonone. It is a well known problem that MathJax fails to render when usingdisplay:none: https://github.com/mathjax/MathJax-docs/wiki/Dealing-with-display:none.The solution I propose in this PR is to add and remove the class
h5p-questionset-visible, instead ofhideandshow, and to then define visibility byvisibility:hidden; position: absolute; left: -100%;.This PR enables me to use MathJax in my questions without any problems.