Add initial Warpwire integration #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR: h5p/h5p-editor-php-library#152 |
|
For testing, you can use this video URL: https://support.warpwire.com/w/CUgAAA/ |
fnoks
reviewed
Jun 2, 2022
scripts/warpwire.js
Outdated
| */ | ||
|
|
||
| var getId = function (url) { | ||
| const matches = url.match(/^[^\/]+:\/\/([^\/]*\.[^\/]+)\/w\/(.+)\/.*$/); |
There was a problem hiding this comment.
Isn't this a bit generic? I.e: Won't warpwire.com always be part of the url?
There was a problem hiding this comment.
It is a bit broad because Warpwire URLs can be whitelabeled. We can improve this regex slightly by changing the \/w\/(.+) to \/w\/[-_0-9a-zA-Z]{6,7}.
|
@fnoks I have merged in the latest master and fixed the one small conflict. Please let me know if there are any other things I need to address or any other questions you have. |
|
I would love to see this integration and also see it in Interactive Video. @fnoks Any chance of approving this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warpwire is a video management and playback platform that is used mostly by educational institutions. It has been requested that we support H5P. To that end, we have created the necessary script and tested it on Moodle and Drupal 7.