Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading .h5p files doesn't work anymore in Moodle if it has newer libraries than the file #468

Open
Urpokarhu1 opened this issue Sep 12, 2022 · 1 comment

Comments

@Urpokarhu1
Copy link

Urpokarhu1 commented Sep 12, 2022

Hello,
There is a problem where if Moodle has newer h5p-libraries than the .h5p file you try to upload it doesn't work and it just reloads forever in the editor window @icc @thomasmars

  • for example if the h5p file has Fill in the Blanks (1.12.11) but Moodle has Fill in the Blanks (1.14.0) but this applies to all other libraries too
  • Course presentation in .h5p file 1.22.11 and Moodle has 1.24.1
@Urpokarhu1 Urpokarhu1 changed the title if Moodle has newer libraries than .h5p you try to upload it doesn't work Uploading .h5p files doesn't work anymore in Moodle if it has newer libraries Sep 12, 2022
@Urpokarhu1 Urpokarhu1 changed the title Uploading .h5p files doesn't work anymore in Moodle if it has newer libraries Uploading .h5p files doesn't work anymore in Moodle if it has newer libraries than the file Sep 12, 2022
@otacke
Copy link
Contributor

otacke commented Sep 27, 2022

This is not a bug in the moodle plugin, but in H5P editor core. The issue should be fixed in h5p/h5p-editor-php-library#144 and would be part of the next plugin update.

It's possible to patch the moodle plugin for now. Just locate the respective file that is changed on your moodle server (should be /mod/hvp/editor/scripts/h5peditor.js) and do the changes done in https://github.com/h5p/h5p-editor-php-library/pull/144/files (adding those two lines of code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants