New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose H5PL low-level API #1256
Conversation
conda-forge overrides the default plugin path when compiling hdf5, so the tests were failing in a conda environment.
This looks good to me! Thanks @takluyver!
Does HDF5 have a lock of its own around this? |
I can't see locking in a quick look at the HDF5 source code, though it's possible that I'm overlooking it in a macro or something. Maybe we should just document for now that it's very likely not thread-safe. |
Seems reasonable for now |
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
=======================================
Coverage 83.82% 83.82%
=======================================
Files 18 18
Lines 2170 2170
=======================================
Hits 1819 1819
Misses 351 351
Continue to review full report at Codecov.
|
Thanks @takluyver! |
This is a continuation of #1166. I've updated it to use the
@insubprocess
decorator @scopatz added, fixed the tests running in a conda environment (conda-forge configures a non-default plugin directory when building HDF5), and added some docs for the new functions.Remaining questions:
I'm tentatively marking this for 2.10, but I don't mind if we bump it to a later release.