Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AttributeManager.create consistent with __setitem__ #1265

Merged
merged 3 commits into from Jul 18, 2019

Conversation

t20100
Copy link
Contributor

@t20100 t20100 commented Jul 15, 2019

This PR moves the call to base.guess_dtype from AttributeManager.__setitem__ to the beginning of AttributeManager.create so that both ways handle the dtype in a consistent way.

This closes #1057

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #1265 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   83.82%   83.83%   +0.01%     
==========================================
  Files          18       18              
  Lines        2170     2172       +2     
==========================================
+ Hits         1819     1821       +2     
  Misses        351      351
Impacted Files Coverage Δ
h5py/_hl/attrs.py 86.4% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596748d...c5ed418. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #1265 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   83.82%   83.83%   +0.01%     
==========================================
  Files          18       18              
  Lines        2170     2172       +2     
==========================================
+ Hits         1819     1821       +2     
  Misses        351      351
Impacted Files Coverage Δ
h5py/_hl/attrs.py 86.4% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596748d...088ae0d. Read the comment docs.

@t20100 t20100 changed the title Make AttributeManager.create consistent with __getitem__ Make AttributeManager.create consistent with __setitem__ Jul 16, 2019
@scopatz
Copy link
Member

scopatz commented Jul 17, 2019

This looks good to me. Can you please add something to the "whatisnew" file?

@t20100
Copy link
Contributor Author

t20100 commented Jul 18, 2019

I updated whatsnew for 2.10.

@scopatz scopatz merged commit 9ad22ee into h5py:master Jul 18, 2019
@scopatz
Copy link
Member

scopatz commented Jul 18, 2019

Thanks!

@t20100 t20100 deleted the sync-attr-create-setter branch October 21, 2019 07:14
@takluyver takluyver modified the milestone: 2.10.1 May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

difference in behavior when writing unicode string to attrs (setter vs .create API)
3 participants