Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/run sonar on gha #68

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Feature/run sonar on gha #68

merged 6 commits into from
Nov 9, 2022

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Aug 24, 2022

@CAMOBAP CAMOBAP self-assigned this Aug 24, 2022
@github-actions
Copy link

github-actions bot commented Aug 24, 2022

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────
      jar │  43.2 KiB │  43.2 KiB │  0 B 
 manifest │     450 B │     450 B │  0 B 
      res │  78.3 KiB │  78.3 KiB │  0 B 
    other │  75.6 KiB │  75.6 KiB │  0 B 
──────────┼───────────┼───────────┼──────
    total │ 197.5 KiB │ 197.5 KiB │  0 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  36 │  36 │ 0 (+0 -0) 
 methods │ 413 │ 413 │ 0 (+0 -0) 
  fields │ 144 │ 144 │ 0 (+0 -0)

sdk/build.gradle Outdated
@@ -45,7 +47,11 @@ android {
}

testOptions {
unitTests.returnDefaultValues = true
animationsDisabled true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no = ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, looks like I lost it during experimenting with jococo report

BTW if we can run our tests without it, I propose to remove unitTests.returnDefaultValues from testOptions

@CAMOBAP CAMOBAP requested a review from e271828- August 25, 2022 09:02
@CAMOBAP CAMOBAP marked this pull request as ready for review August 25, 2022 09:20
@CAMOBAP CAMOBAP mentioned this pull request Aug 25, 2022
2 tasks
@CAMOBAP CAMOBAP requested a review from DSergiu August 25, 2022 17:24
sdk/build.gradle Outdated Show resolved Hide resolved
Co-authored-by: e271828- <e271828-@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@e271828- e271828- merged commit a4a0ddf into main Nov 9, 2022
@e271828- e271828- deleted the feature/run-sonar-on-gha branch November 9, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants