Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): fixed dim background when checkbox is visible #81

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Nov 12, 2022

Closes #72

@CAMOBAP CAMOBAP requested a review from DSergiu November 12, 2022 10:14
@CAMOBAP CAMOBAP self-assigned this Nov 12, 2022
@github-actions
Copy link

github-actions bot commented Nov 12, 2022

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────
      jar │  43.2 KiB │  43.3 KiB │ +93 B 
 manifest │     450 B │     450 B │   0 B 
      res │  78.3 KiB │  78.3 KiB │   0 B 
    other │  75.6 KiB │  75.6 KiB │   0 B 
──────────┼───────────┼───────────┼───────
    total │ 197.5 KiB │ 197.6 KiB │ +93 B 

 JAR     │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  36 │  36 │  0 (+0 -0) 
 methods │ 413 │ 414 │ +1 (+1 -0) 
  fields │ 144 │ 146 │ +2 (+2 -0)
AAR
 size     │ diff  │ path          
──────────┼───────┼───────────────
 43.3 KiB │ +93 B │ ∆ classes.jar 
──────────┼───────┼───────────────
 43.3 KiB │ +93 B │ (total)
MANIFEST
              │ old              │ new              
──────────────┼──────────────────┼──────────────────
 package      │ com.hcaptcha.sdk │ com.hcaptcha.sdk 
 version code │ 23               │ 24               
 version name │ 3.3.5            │ 3.3.6            

@@ -1,4 +1,4 @@
 <manifest
-    android:versionCode=23
-    android:versionName=3.3.5
+    android:versionCode=24
+    android:versionName=3.3.6
     package=com.hcaptcha.sdk
JAR
METHODS:

   old │ new │ diff       
  ─────┼─────┼────────────
   413 │ 414 │ +1 (+1 -0) 
  + android.view.Window getAttributes() → WindowManager_LayoutParams
  

FIELDS:

   old │ new │ diff       
  ─────┼─────┼────────────
   144 │ 146 │ +2 (+2 -0) 
  + com.hcaptcha.sdk.HCaptchaDialogFragment defaultDimAmount: float
  + android.view.WindowManager_LayoutParams dimAmount: float

@DSergiu DSergiu changed the title #72 always dim background if checkbox is visible (regardless loading config) fix(dialog): fixed dim background when checkbox is visible Nov 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@e271828- e271828- merged commit d723903 into main Nov 21, 2022
@e271828- e271828- deleted the bugfix/dimming-for-loading-false-config branch November 21, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox dialog: background not dimmed
3 participants