validate example image resources #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DicksonChi
requested review from
alidzm,
spirit-q2,
igervasiychuk and
RafalBielickiIM
spirit-q2
approved these changes
Jun 9, 2023
e271828-
reviewed
Jun 9, 2023
There was a problem hiding this comment.
this reminds me we need to drop schematics and standardize on pydantic. it'll block us from upgrading since it's no longer maintained. (unless we switch to schematics/schematics#595)
| return answer_uris | ||
|
|
||
|
|
||
| def validate_requester_restricted_answer_set_uris(restricted_answer_set: dict) -> None: |
There was a problem hiding this comment.
thanks for remembering about this one!
e271828-
approved these changes
Jun 9, 2023
igervasiychuk
approved these changes
Jun 9, 2023
basemodels/pydantic/manifest/data/requester_question_example.py
Outdated
Show resolved
Hide resolved
created a jira ticket for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.