Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing support for schematics and leaving only pydantic #98

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Removing support for schematics and leaving only pydantic #98

merged 7 commits into from
Oct 16, 2023

Conversation

DicksonChi
Copy link
Contributor

No description provided.

@DicksonChi DicksonChi marked this pull request as draft July 18, 2023 14:24
@DicksonChi DicksonChi marked this pull request as ready for review October 11, 2023 19:25
@DicksonChi DicksonChi changed the title Removing schematics and moving to pydantic Removing support for schematics and leaving only pydantic Oct 12, 2023
RafalBielickiIM
RafalBielickiIM reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@RafalBielickiIM RafalBielickiIM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really nice, would be good to bump some libs while we are at it

pyproject.toml Show resolved Hide resolved
RafalBielickiIM
RafalBielickiIM reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@RafalBielickiIM RafalBielickiIM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update readme as there is schematic example

RafalBielickiIM
RafalBielickiIM approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@RafalBielickiIM RafalBielickiIM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DicksonChi DicksonChi merged commit dda1845 into master Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalBielickiIM RafalBielickiIM RafalBielickiIM approved these changes

@igervasiychuk igervasiychuk Awaiting requested review from igervasiychuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DicksonChi @RafalBielickiIM