Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add esm build & Fix the Vite TS issue #139

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Add esm build & Fix the Vite TS issue #139

merged 3 commits into from
Jun 28, 2022

Conversation

zoryana94
Copy link
Contributor

Issue: #131

Screenshots:

Vite TS:

Знімок екрана 2022-06-20 о 16 52 25

Local:

Знімок екрана 2022-06-20 о 16 55 38

DSergiu
DSergiu reviewed Jun 20, 2022
View reviewed changes
package.json Show resolved Hide resolved
DSergiu
DSergiu reviewed Jun 20, 2022
View reviewed changes
package.json Show resolved Hide resolved
DSergiu
DSergiu reviewed Jun 20, 2022
View reviewed changes
types/index.d.ts Outdated Show resolved Hide resolved
@zoryana94 zoryana94 changed the title Fix the Vite TS issue Add esm build & Fix the Vite TS issue Jun 20, 2022
brdlyptrs
brdlyptrs reviewed Jun 20, 2022
View reviewed changes
package.json Outdated
@@ -3,18 +3,21 @@
"version": "1.3.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update version, do we need to specify any breaking changes with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are not breaking, I specifically added that "add-module-exports" plugin, so it's all compatible
it should be safe to bump it to "1.4.0", however, we can also update it to "2.0.0"
I'd update the version after we merge that "Revert" PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0.0 might be good if we add this PR to it as well. @DSergiu what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR is a bug fix, not breaking change. The esm here is just a "new feature", not seeing it as a breaking change. IMO next version should be 1.5.0 for this PR. For the other PR, 1.5.1 if released afterwards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, it's for "1.4.0", not "1.5.0"
the current version is "1.3.1"

DSergiu
DSergiu reviewed Jun 21, 2022
View reviewed changes
package.json Show resolved Hide resolved
DSergiu
DSergiu reviewed Jun 21, 2022
View reviewed changes
src/index.js Show resolved Hide resolved
brdlyptrs
brdlyptrs previously approved these changes Jun 27, 2022
View reviewed changes
@zoryana94 zoryana94 merged commit 182874b into master Jun 28, 2022
@natnat-mc natnat-mc mentioned this pull request Jul 7, 2022
Closed
@brdlyptrs brdlyptrs deleted the vite-ts-fix branch July 8, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSergiu DSergiu DSergiu approved these changes

@brdlyptrs brdlyptrs brdlyptrs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zoryana94 @DSergiu @brdlyptrs