Load JPEG files independent of suffix #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cleaned up load() * added dirty hack to load() (see comments) * added test for loading tests/images/02.docx (a jpeg file with wrong suffix) * all tests still working
|
Changes Unknown when pulling 113689e on FelixHaller:master into * on hMatoba:master*. |
|
Ah and it's not working in python2.7 because of changed |
* STILL DIRTY!
|
Changes Unknown when pulling 589015f on FelixHaller:master into * on hMatoba:master*. |
|
I added a parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is in the _ExifReader initialiser. I added a test and an example file (copy of 02.jpg). I think load() has to be redesigned. Please check code and comments and tell me what you think.