New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #40

Merged
merged 5 commits into from Sep 10, 2017

Conversation

Projects
None yet
3 participants
@mpenkov
Contributor

mpenkov commented Sep 10, 2017

一つのテストが落ちるけど、エンコードに無関係かもしれません。

======================================================================
ERROR: test_dump_and_load_specials (s_test.ExifTests)
test dump and load special types(SingedByte, SiginedShort, DoubleFloat)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tests/s_test.py", line 359, in test_dump_and_load_specials
    exif_bytes = piexif.dump(exif_dict)
  File "/Users/misha/git/Piexif/piexif/_dump.py", line 63, in dump
    zeroth_set = _dict_to_bytes(zeroth_ifd, "0th", 0)
  File "/Users/misha/git/Piexif/piexif/_dump.py", line 314, in _dict_to_bytes
    offset)
  File "/Users/misha/git/Piexif/piexif/_dump.py", line 280, in _value_to_bytes
    length_str = struct.pack(">I", length)
UnboundLocalError: local variable 'length' referenced before assignment
@hMatoba

This comment has been minimized.

Show comment
Hide comment
@hMatoba

hMatoba Sep 10, 2017

Owner

Thanks.

Owner

hMatoba commented Sep 10, 2017

Thanks.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 10, 2017

Coverage Status

Changes Unknown when pulling af8fc2a on mpenkov:dev into ** on hMatoba:dev**.

coveralls commented Sep 10, 2017

Coverage Status

Changes Unknown when pulling af8fc2a on mpenkov:dev into ** on hMatoba:dev**.

@hMatoba hMatoba merged commit b124dc9 into hMatoba:dev Sep 10, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on dev at 97.5%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment