Exit if child process creation fails

chromaterm/platform/windows.py

@@ -190,9 +190,13 @@ class STARTUPINFOEX(ctypes.Structure):
 
     # EXTENDED_STARTUPINFO_PRESENT = 0x80000
     process_info = PROCESS_INFORMATION()
-    K32.CreateProcessW(None, subprocess.list2cmdline(program_args), None, None,
-                       False, 0x80000, None, None,
-                       byref(startup_info_ex.StartupInfo), byref(process_info))
+    if not K32.CreateProcessW(None, subprocess.list2cmdline(program_args),
+                              None, None, False, 0x80000, None, None,
+                              byref(startup_info_ex.StartupInfo),
+                              byref(process_info)):
+        message = ctypes.FormatError()
+        K32.ClosePseudoConsole(console)
+        sys.exit(message)
 
     # Create pipe and necessary forwarder threads
     master, slave = create_socket_pipe()

tests/platform/test_windows.py

@@ -150,10 +150,8 @@ def test_run_program_incompatible_windows_version(monkeypatch):
     patch_functions(monkeypatch)
     platform.WINDOWS_BUILD_CURRENT = platform.WINDOWS_BUILD_MINIMUM - 1
 
-    try:
+    with pytest.raises(SystemExit, match='Windows version not supported'):
         platform.run_program([])
-    except SystemExit:
-        pass
 
 
 def test_run_program_close_program_handles(monkeypatch):
@@ -175,6 +173,17 @@ def test_run_program_escape_program_args(monkeypatch):
     assert platform.K32.CreateProcessW.mock_calls[0][1][1] == '"foo bar" 1 2'
 
 
+def test_run_program_create_process_error(monkeypatch):
+    '''If an error is encountered during process creation, ChromaTerm should exit
+    with the relevant message from `GetLastError`.'''
+    patch_functions(monkeypatch)
+    monkeypatch.setattr(ctypes, 'FormatError', lambda: 'Hello', raising=False)
+    platform.K32.CreateProcessW.return_value = False
+
+    with pytest.raises(SystemExit, match='Hello'):
+        platform.run_program([])
+
+
 def test_run_program_read(monkeypatch):
     '''Confirm ChromaTerm _reads_ the program's _output_ (output_r).'''
     patch_functions(monkeypatch)