Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring and any Improvement #4

Open
ha-yi opened this issue Oct 4, 2018 · 2 comments
Open

Refactoring and any Improvement #4

ha-yi opened this issue Oct 4, 2018 · 2 comments
Labels
enhancement hacktoberfest help wanted

Comments

@ha-yi
Copy link
Owner

ha-yi commented Oct 4, 2018

Add any improvement and suggestions for this library.
@subbramanil
Copy link
Contributor

Looks like it's been quite a lot of time since the issue was opened. I would like to take a stab at it. Pls, assign it to me.

  1. Update to the latest versions of gradle, android libraries & resolve compilation issues
  2. Refactor and Improve the code
  3. Update the Sample App and add some new screenshots

@subbramanil
Copy link
Contributor

subbramanil commented Sep 25, 2020 •
edited
Loading

@ha-yi

I submitted a couple of pull requests(#6, #7) that address the 1 & 2. Please review and merge them in the same order to get clarity of the changes made. I will submit another PR for the sample app, screenshots & readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ha-yi @subbramanil