Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails on peer_test #6

Closed
ghost opened this issue Jul 6, 2011 · 1 comment
Closed

Test fails on peer_test #6

ghost opened this issue Jul 6, 2011 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 6, 2011

it_passes_pkg_peer: [FAIL]
+ cd pkg/peer
+ gotest
rm -f _test/doozer/peer.a
6g -o gotest.6 peer.go liveness.go version.go bench_test.go liveness_test.go misc_test.go peer_test.go
peer_test.go:346: undefined: exec.Run
make: *** [gotest.6] Error 1

gotest: "/local/go/bin/gomake testpackage GOTESTFILES=bench_test.go liveness_test.go misc_test.go peer_test.go" failed: exit status 2

Tests: 9 | Passed: 8 | Failed: 1

latest Go weekly replaces exec.Run() with exec.Command + command.Run

Here are diffs for a (partial) fix to peer_test.go:

rnm-macpro(1063)packages: diff doozerd/src/pkg/peer/peer_test.go doozerd.fixed/src/pkg/peer/peer_test.go
344,354c344,347
< func runDoozer(a ...string) *exec.Cmd {
< path := "/home/kr/src/go/bin/doozerd"
< p, err := exec.Run(
< path,
< append([]string{path}, a...),
< nil,
< "/",
< 0,
< 0,
< 0,

< )

func runDoozer(args ...string) {
path := "/local/bin/doozerd"
p := exec.Command(path, args...)
err := p.Run()
358d350
< return p
rnm-macpro(1064)packages:

@bmizerany
Copy link
Contributor

This looks like a dependency on an older version of Go that should be fixed with the lastest Go weekly and doozerd master branch. Please try building with that combination and let me know if you have any more problems by opening this ticket back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant