patch for random proxy selection #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audibleblink
force-pushed
the
master
branch
2 times, most recently
from
22977f3
to
4c109a8
Compare
|
Addresses #72 |
|
@audibleblink @haad I noticed this also, the randomness was completely based on epoch time which meant if a bunch of connections came in at once (within the same second) they would in effect not be randomized from one another. I can't think of any reason that would be desired behavior and would also prefer this "true randomness" behavior you're proposing. Unless the original behavior was by design and desired for some reason? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting between multiple random_proxies, and given network connections that resolve in under a second, proxychains will send subsequent requests through the same proxy. In my testing, up to 8 requests can go out through the same proxy. This patch ensures that only one network connection per proxy occurs.