Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MKL pinning, latest releases are fixed #71

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

haasad
Copy link
Owner

@haasad haasad commented Mar 28, 2024

Latest PyPI releases 2024.1 are fixed, however they are not available yet on conda-forge, so we explicitly exlude the problematic 2024.0 version instead of the previous pin to <2024

See also #58

@haasad haasad changed the title Remove MKL pinning, latest releases are fixed Update MKL pinning, latest releases are fixed Mar 28, 2024
@haasad haasad merged commit 9ef2095 into master Mar 28, 2024
25 checks passed
@haasad haasad deleted the remove-mkl-pin branch March 28, 2024 21:28
@ma-sadeghi
Copy link

@haasad Would it make sense to set an upper bound of 2025? Since every year new mkl builds break pypardiso, that would safeguard against it, and you'd just need to update the upper bounds once a year.

@haasad
Copy link
Owner Author

haasad commented Mar 30, 2024

Hi @ma-sadeghi, I also considered it but decided against it. I had a look a some of the previous issues and there isn't a clear pattern where major MKL versions cause issues. E.g #26 was caused by python 3.9 dropping support for a old dependency, #12 was caused by MKL 2021.2.0, #36 was caused by a new incompatible release of intel-openmp where mkl itself didn't properly pin it (here the release of MKL 2022.0 actually made the install work again). The same problem as #36 happened again with intel-openmp 2023.0, however MKL now sets the correct pins (see conda-forge/intel_repack-feedstock#33 and conda-forge/intel_repack-feedstock#50) and this particular problem shouldn't appear anymore.

As far as I can tell, mkl 2024.0 was the first major release, where the MKL release itself was the problem.

haasad added a commit to regro-cf-autotick-bot/pypardiso-feedstock that referenced this pull request Mar 30, 2024
@ma-sadeghi
Copy link

Awesome, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants