-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goto build error on MinGW #185
Comments
cc @kasper93 I don't understand heads nor tails of this |
Another thing that is not tested on CI? I'll send MR to fix this when I get time. |
Oh, I understood now why it's failing, it's being included from a C++ file, and apparently jumping past an initialization is an error there even if the initialization is of a C struct?? |
Yes, exactly. And I was even thinking about it before, but forgot that we actually have one C++ file, which is disabled when shaderc is found. So not really something I tested. Too much faith in CI coverage :) |
Fixes compilation of glslang.cc due to more strict C++ prohibiting to jump over variable initialization. Also as a bonus check sleep time after converting to integer as it may end up zero. Fixes: haasn/libplacebo#185
Running into this build error and warning with MinGW and placebo (latest commit)
My temporary workaround: master...DeadSix27:libplacebo:patch-1
My C skill isn't up to par though.
The error:
The text was updated successfully, but these errors were encountered: