Skip to content

Commit

Permalink
[RELEASE] Release of 2.1.1
Browse files Browse the repository at this point in the history
  • Loading branch information
Richard Haeser committed Sep 23, 2020
1 parent 6564d5d commit 38a1ff5
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions Classes/Command/CheckPageSpeedInsightsCommand.php
Expand Up @@ -47,21 +47,21 @@ public function execute(InputInterface $input, OutputInterface $output)

$url = PageSpeedInsightsUtility::getUrlForPage($pid, $languageId);

$strategies = $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['strategies'] ?: ['performance', 'seo', 'accessibility', 'best-practices', 'pwa'];
$pageSpeedInsightsResultsMobile = PageSpeedInsightsUtility::checkUrl($url, 'mobile', $strategies, $reference, $pageId, $languageId, $pid, (string)$input->getArgument('key'));
$categories = $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['categories'] ?: ['performance', 'seo', 'accessibility', 'best-practices', 'pwa'];
$pageSpeedInsightsResultsMobile = PageSpeedInsightsUtility::checkUrl($url, 'mobile', $categories, $reference, $pageId, $languageId, $pid, (string)$input->getArgument('key'));
if (array_key_exists('error', $pageSpeedInsightsResultsMobile)) {
$errors = 10;
$output->writeln('<error>' . $row['uid'] . ': Check for ' . $url . ' failed for mobile. Error message: ' . $pageSpeedInsightsResultsMobile['error']['message'] . '</error>');
} else {
$output->writeln($row['uid'] . ': ' . $row['slug'] . ': ' . $url . ' (' . implode(', ', $strategies) . ') succeeded for mobile');
$output->writeln($row['uid'] . ': ' . $row['slug'] . ': ' . $url . ' (' . implode(', ', $categories) . ') succeeded for mobile');
}

$pageSpeedInsightsResultsDesktop = PageSpeedInsightsUtility::checkUrl($url, 'desktop', $strategies, $reference, $pageId, $languageId, $pid, (string)$input->getArgument('key'));
$pageSpeedInsightsResultsDesktop = PageSpeedInsightsUtility::checkUrl($url, 'desktop', $categories, $reference, $pageId, $languageId, $pid, (string)$input->getArgument('key'));
if (array_key_exists('error', $pageSpeedInsightsResultsDesktop)) {
$errors = 10;
$output->writeln('<error>' . $row['uid'] . ': Check for ' . $url . ' failed for desktop. Error message: ' . $pageSpeedInsightsResultsDesktop['error']['message'] . '</error>');
} else {
$output->writeln($row['uid'] . ': ' . $row['slug'] . ': ' . $url . ' (' . implode(', ', $strategies) . ') succeeded for desktop');
$output->writeln($row['uid'] . ': ' . $row['slug'] . ': ' . $url . ' (' . implode(', ', $categories) . ') succeeded for desktop');
}
}

Expand Down
4 changes: 2 additions & 2 deletions Documentation/Configuration/Index.rst
Expand Up @@ -51,11 +51,11 @@ By default, your results are shown for mobile devices. If you want to view the r

Only check specific strategies
------------------------------
Sometimes you are just not interested in all strategies. By overriding :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['strategies']` you can define which strategies should be checked. If you want to disable the check on PWA features, you just use the following lines of code.
Sometimes you are just not interested in all categories. By overriding :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['categories']` you can define which categories should be checked. If you want to disable the check on PWA features, you just use the following lines of code.

.. code-block:: php
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['strategies'] = [
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['categories'] = [
'performance',
'seo',
'accessibility',
Expand Down
2 changes: 1 addition & 1 deletion ext_emconf.php
Expand Up @@ -10,7 +10,7 @@
'uploadfolder' => 0,
'createDirs' => '',
'clearCacheOnLoad' => 0,
'version' => '2.1.0',
'version' => '2.1.1',
'constraints' => [
'depends' => [
'typo3' => '9.5.0 - 10.4.99'
Expand Down
2 changes: 1 addition & 1 deletion ext_localconf.php
Expand Up @@ -28,7 +28,7 @@
);
}

$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['strategies'] = [
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['categories'] = [
'performance',
'seo',
'accessibility',
Expand Down

0 comments on commit 38a1ff5

Please sign in to comment.