Tox libraries are not linked properly to tox.so #17
Comments
|
After i did the following fix 78b0621 it works for me now |
gordon-quad
changed the title
|
That's my bad -- I assumed the newer version of toxcore built a monolithic shared object, but it looks like it depends on whether or not toxcore is built with cmake or autotools. Our CMake find module for Tox will have to work for both of these situations. |
|
According to conversation in IRC cmake is preferred way of building toxcore and autotools script needs updating, so I suppose its time to fix gentoo ebuilds and get single libtoxcore.so. But since they are not going to fix autotools script soon it still would be nice to support both monolithic and split versions in FindTox.cmake if it will not be too difficult to implement. |
haavard
added a commit
that referenced
this issue
Apr 30, 2018
toxcore may be built as either a single monolithic library, or multiple libraries (core, AV, encrypted savefiles). This updates the CMake find module to work in both configurations. Fixes <#17>.
|
Should be fixed in the commit above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After commit 1cc1aa2 make produced tox.so which is not linked to libtoxav.so and libtoxencryptsave.so which leads to inability to load tox.so in weechat:
I am using c-toxcore from git and it seems that it never produced single libtoxcore.so with everything linked inside. I wonder why did you change FindTox.cmake to exclude those libraries from Tox_LIBRARIES cmake variable?
The text was updated successfully, but these errors were encountered: