Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots seem to be supported only if they are PNG #45

Open
chrisjdavis opened this issue Apr 8, 2013 · 4 comments
Open

Screenshots seem to be supported only if they are PNG #45

chrisjdavis opened this issue Apr 8, 2013 · 4 comments
Labels

Comments

@chrisjdavis
Copy link
Contributor

Not sure if this is a defect or not, but I was creating jpgs for my plugins, and they aren't being picked up. Mostly we need to decide if PNG is the format we are enforcing, or will we allow other formats.

@Konzertheld
Copy link
Member

+1 to supporting JPEGs, too. While PNG is very common in Unix environments, JPEG is more common in Windows. I don't see adavantages in one of them for what we use them for, so for user-friendliness, we should support both.

@not-mikelietz
Copy link

Currently 'screenshot.png' is hardcoded. It could be changed, certainly.

On Mon, Apr 8, 2013 at 7:24 PM, Konzertheld notifications@github.comwrote:

+1 to supporting JPEGs, too. While PNG is very common in Unix
environments, JPEG is more common in Windows. I don't see adavantages in
one of them for what we use them for, so for user-friendliness, we should
support both.


Reply to this email directly or view it on GitHubhttps://github.com//issues/45#issuecomment-16085349
.

@rick-c
Copy link
Member

rick-c commented Apr 9, 2013

Since Habari itself allows either a png, jpg, gif, it would be best to allow the same in the directory.

@mikelietz
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants