Undelete plugin doesn't account for deleted users

[rick-c]

If one deletes a user with the undelete plugin active, and tell Habari to delete the user's posts, the posts are not permanently deleted. They are just marked as deleted. If one then goes to the manage posts page, one sees the following error for the deleted user's posts:

Notice: Trying to get property of non-object in system/admin/post_items.php line 21

In line 21, Habari is looking for the post author, which no longer exists.

[mikelietz]

I think deleting a user should take precedence over a plugin allowing posts to be undeleted.

[michaeltwofish]

Or should the undelete plugin allow the undeletion of users?

[mikelietz]

I don't think the undelete plugin should allow users to be undeleted. Since
users don't have a status, just permissions, it'd not be quite as easy as,
well, creating another group of users for 'deleted' users which would have,
what, no privileges at all? Would we want to go down that path?

On Sat, Dec 3, 2011 at 7:54 AM, Michael C. Harris <
reply@reply.github.com

wrote:

Or should the undelete plugin allow the undeletion of users?

---

Reply to this email directly or view it on GitHub:
#253 (comment)

[michaeltwofish]

Probably not at this stage.

[chrisjdavis]

Regardless of what we want to do long term, the bug at hand should be addressed. The options on the table seem to be actually deleting the posts, since the user is gone, or gracefully handling the call to the author. I am in favor of hard deleting the posts, since during user deletion the option of moving the posts to another user is available.

If that option isn't chosen, we should assume that the intention is to have those posts burninated. Or, you know, the user didn't see the option to move posts.

Thoughts?

[rick-c]

I'd agree. If a user is deleted without reassigning the posts to another user, the assumption should be that all that user's posts should be permanently deleted.

[michaeltwofish]

Agreed. In the long term, we should have a much more robust system for undoing everything, a la gmail, but for now just nuke em.

[chrisjdavis]

Werd on that Michael. Architecting that universal undo system will be an interesting task.