Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, fix refresh, and add openPosition setting #1

Merged
merged 6 commits into from
Dec 20, 2019

Conversation

mbudnek
Copy link
Contributor

@mbudnek mbudnek commented Nov 24, 2019

These are the changes I've made to my local copy of this driver. The main points are:

  1. Clean up formatting
  2. Fix the refresh command to work properly if the "reverse direction" setting is enabled
  3. Add an "open position" setting instead of using a global, hard-coded value
  4. De-duplicate a bunch of code and use a single setLevel method for all position control
  5. Port the battery level refresh code over from the smartthings driver

@habhomegit habhomegit merged commit 36f9d79 into habhomegit:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants