[php] Add gcc-libs to pkg_deps

[smacfarlane]

This PR resolves downstream build errors in Drupal

https://bldr.habitat.sh/#/pkgs/core/drupal/jobs/1103619923366256640

Signed-off-by: Scott Macfarlane smacfarlane@chef.io

[thesentinels]

Thanks for the pull request! Here is what will happen next:

1. Your PR will be reviewed by the maintainers
2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

[predominant]

LGTM!

[universam1]

consider the comment above why the LD_LIBRARY_PATH is actually necessary

[universam1]

this will break libzip support!

Suggested change

	./configure --prefix="${pkg_prefix}" \
	LD_LIBRARY_PATH="$(pkg_path_for gcc)/lib" ./configure --prefix="${pkg_prefix}" \

[smacfarlane]

I wrote the comment, and it's wrong 😞. The underlying issue was that core/gcc-libs wasn't in the pkg_deps therefore the conftest binaries were unable to execute, not that the path was being manipulated.

The above LD_LIBRARY_PATH modifies only the runtime for ./configure and has no effect on commands executed later in the build, or in the runtime for the php package. Since this change adds core/gcc-libs to the pkg_deps, ./configure is able complete successfully without setting LD_LIBRARY_PATH, so LD_LIBRARY_PATH and the comment can safely be removed.

I've put together a small test case to validate. Note: I'm not a php dev, so suggestions on correctness are welcome 😄

Given the following php:

<?
  $za = new ZipArchive;
  $za->open('test.zip',ZipArchive::CREATE|ZipArchive::OVERWRITE);
  $za->addFile("php/plan.sh");
  $za->close();
?>

When executing it under core/php/7.2.8/20181008145855 (current stable):

[31][default:/src:0]# hab pkg exec core/php/7.2.8/20181008145855 php test.php

Fatal error: Uncaught Error: Class 'ZipArchive' not found in /src/test.php:2
Stack trace:
#0 {main}
  thrown in /src/test.php on line 2

When executed it on a build with these changes:

[32][default:/src:0]# hab pkg exec smacfarlane/php php test.php
[33][default:/src:0]# unzip -l test.zip
Archive:  test.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
     2027  2018-10-30 14:45   php/plan.sh
---------                     -------
     2027                     1 file

[predominant]

🎉 👍 💯 🥇

[predominant]

@smacfarlane How about adding these steps to a test we can include? That would prevent any zip regression in the future.

[smacfarlane]

@predominant Done!

@universam1 Does the above address your concerns?

[universam1]

Cool, I’ll try!

[smacfarlane]

@universam1 I'm going to merge this, please open an issue if the resulting packages do not contain libzip support.