New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to unix-style line endings #1963

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@chefsalim
Member

chefsalim commented Nov 5, 2018

We are running into issues with scripting that uses the core plans directory manifest because the node 6 plan.ps1 file has Windows line endings. This fix converts the line endings to Unix style. This conforms with other Windows ps1 files (eg, node10).

Signed-off-by: Salim Alam salam@chef.io

tenor-138747032

@chefsalim chefsalim requested a review from habitat-sh/habitat-core-plans-maintainers as a code owner Nov 5, 2018

@thesentinels

This comment has been minimized.

Contributor

thesentinels commented Nov 5, 2018

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Convert to unix-style line endings
Signed-off-by: Salim Alam <salam@chef.io>

@chefsalim chefsalim force-pushed the SA/fix-plan branch from f5deef0 to 9373727 Nov 5, 2018

@chefsalim chefsalim merged commit 0e7e60e into master Nov 5, 2018

2 checks passed

DCO This commit has a DCO Signed-off-by line
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chefsalim chefsalim deleted the SA/fix-plan branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment