[aws-cli] Add plan.ps1 to aws-cli

[tduffield]

Signed-off-by: Tom Duffield tom@chef.io

[chef-expeditor]

Hello tduffield! Thanks for the pull request!

Here is what will happen next:

1. Your PR will be reviewed by the maintainers.
2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

[mwrock]

I would have thought that this would have required you to pip install virtualenv. With python3 you should be able to use python's venv: python -m venv $pkg_prefix

[tduffield]

I get an error that says the venv module does not exist.

[mwrock]

weird, looking at the packages that is in 3.6 but missing in 3.7. Our build is the same for both so it seems like it is missing from source. investigating...

[smacfarlane]

I think the virtualenv isn't doing what we expect it to do:

PS C:\Users\Administrator\core-plans> cat C:\hab\pkgs\core\aws-cli\1.16.153\20190507142534\Scripts\aws
#!C:\hab\studios\Users--Administrator--core-plans\hab\pkgs\core\aws-cli\1.16.153\20190507142534\Scripts\python.exe
# Copyright 2012 Amazon.com, Inc. or its affiliates. All Rights Reserved.

Running hab pkg exec core/aws-cli aws help results in:

✗✗✗
✗✗✗ %1 is not a valid Win32 application. (os error 193)
✗✗✗

hab pkg exec core/aws-cli aws.cmd help does behave correctly.

Is it expected that a user should run aws.cmd on windows instead of aws like they would on linux?

[tduffield]

@smacfarlane that has been my experience with a number of different apps, not just python apps. Ruby apps as well require you to call thing.bat instead of thing.

[smacfarlane]

@tduffield 👍 It looks like the #! issue may be related to habitat-sh/habitat#6483 which means solving it here would be non-trivial. I'll file an issue to loop back on this plan once that is resolved.

Would you mind adding a small note to the Usage section of the README that users should call aws.cmd on Windows instead of aws?