Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Unload' hook #2485

Closed
baggerspion opened this issue May 23, 2017 · 1 comment · Fixed by #4236
Closed

'Unload' hook #2485

baggerspion opened this issue May 23, 2017 · 1 comment · Fixed by #4236
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Feature Issues that describe a new desired feature
Milestone
Accepted Minor

Comments

@baggerspion
Copy link
Contributor

baggerspion commented May 23, 2017 •
edited

Preamble

Introduce an "unload" hook for performing tasks each time that hab stop is called for a service.

Example use case

  • The core/drupal plan background loads core/nginx in the init hook.
  • When the user runs hab stop core/drupal the core/nginx instance is left running.
  • An unload hook would allow the plan writer to additionally stop the nginx which is now cruft.
@reset reset added this to the Accepted Minor milestone May 26, 2017
@reset
Copy link
Collaborator

reset commented May 26, 2017

@therealpadams yeah we'll definitely do this 👍

rsertelon added a commit to rsertelon/habitat that referenced this issue Dec 6, 2017
@rsertelon
Adds post-stop hook
427d272 
This should fix habitat-sh#2485

Signed-off-by: Romain Sertelon <romain@sertelon.fr>
@rsertelon rsertelon mentioned this issue Dec 6, 2017
Merged
rsertelon added a commit to rsertelon/habitat that referenced this issue Dec 6, 2017
@rsertelon
Adds post-stop hook
09199b1 
This should fix habitat-sh#2485

Signed-off-by: Romain Sertelon <romain@sertelon.fr>
@rsertelon rsertelon mentioned this issue Dec 7, 2017
Closed
@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Feature Issues that describe a new desired feature and removed A-supervisor labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Feature Issues that describe a new desired feature
Projects
None yet
Milestone
Accepted Minor
Development

Successfully merging a pull request may close this issue.

Adds post-stop hook rsertelon/habitat
4 participants
@reset @christophermaier @eeyun @baggerspion