trying to make the u64 error irrelevant #1750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
Signed-off-by: Steven Murawski <steven.murawski@gmail.com>
smurawski
force-pushed
the
smurawski/broken_serialization
branch
from
f4178aa
to
83098a6
Compare
reset
reviewed
Feb 10, 2017
| pub service_config_http_listen: http_gateway::ListenAddr, | ||
| pub service_config_http_listen: HttpGatewayListenAddr, | ||
| // Currently only used by `Package` | ||
| pub package_config_from: Option<String>, |
There was a problem hiding this comment.
This is removed in the master branch. You'll want to make sure it's dropped here, too
reset
reviewed
Feb 10, 2017
| } | ||
|
|
||
| #[derive(PartialEq, Eq, Debug, Clone)] | ||
| pub struct HttpGatewayListenAddr { |
There was a problem hiding this comment.
This is called the newtype pattern. In that pattern, it's recommended to use the tuple style struct instead of named fields
reset
reviewed
Feb 10, 2017
| } | ||
| } | ||
|
|
||
| fn gen_census_list() -> CensusList { |
There was a problem hiding this comment.
This is gone in master, too
christophermaier
added
Focus:Supervisor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steven Murawski steven.murawski@gmail.com