Add .first to bind
#2275
Merged
Add .first to bind
#2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bind` and `svc` should feel fairly similar. This will add the `first` field to the bind struct to enable consumers of a service group through a bind to have access to that field as well Signed-off-by: Jamie Winsor <jamie@vialstudios.com>
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
reset
commented
May 9, 2017
| @@ -37,12 +37,16 @@ impl<'a> Binds<'a> { | |||
|
|
|||
| #[derive(Clone, Debug, Serialize)] | |||
| pub struct BindGroup<'a> { | |||
| members: Vec<SvcMember<'a>>, | |||
| pub first: Option<SvcMember<'a>>, | |||
There was a problem hiding this comment.
Optional binds may never populate with members, so we need to have this be an Option
|
If anyone objects feel free to comment after this merge! @thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
christophermaier
added
Focus:Supervisor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindandsvcshould feel fairly similar. This will add thefirstfield to the bind struct to enable consumers of a service group through
a bind to have access to that field as well
Related to #2253