Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper default path for depot data path in builder-api plan #2333

Merged
merged 1 commit into from May 12, 2017
Merged

Set proper default path for depot data path in builder-api plan #2333

merged 1 commit into from May 12, 2017

Conversation

reset
Copy link
Collaborator

@reset reset commented May 12, 2017

tenor-138335306

@reset
Set proper default path for depot data path in builder-api plan
ec487b0 
Signed-off-by: Jamie Winsor <jamie@vialstudios.com>
@reset reset added the Bug label May 12, 2017
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@chefsalim
Copy link
Contributor

Looks good to me. @thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 22dec62 into master May 12, 2017
@thesentinels thesentinels deleted the proper-data-path branch May 12, 2017 01:34
@eeyun eeyun added C-bug and removed Bug labels Jun 6, 2017
@christophermaier christophermaier added Type: Bug Issues that describe broken functionality and removed C-bug labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Issues that describe broken functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@reset @thesentinels @chefsalim @christophermaier @eeyun