Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog posts: A journey with habitat on ECS parts 1 and 2 #3133

Merged
merged 3 commits into from Sep 13, 2017

Conversation

irvingpop
Copy link

@irvingpop irvingpop commented Sep 12, 2017

TODO:

  • Figure out how to add a bio entry
  • Find an acceptance site (if one exists) so I can preview these posts

These are being ported over from my Medium posts:

@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@christophermaier
Copy link
Contributor

@irvingpop You can add your bio information to this file

Also, once your posts are ready, one of the core team members can tell our bot to deploy this to our acceptance environment, where you can check it out (https://www.acceptance.habitat.sh/blog/). Once you're satisfied, we can get these merged!

Irving Popovetsky added 2 commits September 13, 2017 10:01
Signed-off-by: Irving Popovetsky <irving@chef.io>
Signed-off-by: Irving Popovetsky <irving@chef.io>
@irvingpop
Copy link
Author

thanks @christophermaier ! Added a bio entry for myself, rebased and pushed. Could somebody please deploy to acceptance?

@christophermaier
Copy link
Contributor

@irvingpop sure thing!

@thesentinels acceptance

@thesentinels
Copy link
Contributor

🤘 I am sending your branch against master to our acceptance environment.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started the deployment of acceptance.

@thesentinels
Copy link
Contributor

💖 Travis CI reports acceptance has been deployed.

I love new and shiny websites!

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

Signed-off-by: Irving Popovetsky <irving@chef.io>
@irvingpop irvingpop changed the title [WIP] Blog posts: A journey with habitat on ECS parts 1 and 2 Blog posts: A journey with habitat on ECS parts 1 and 2 Sep 13, 2017
@irvingpop
Copy link
Author

Thanks @christophermaier ! Looks good in acceptance. I fixed one small typo and a link - I've removed the [WIP] flag from this, ready to ship when y'all are

@christophermaier
Copy link
Contributor

@irvingpop weeeeeeeeee!

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 0ff9083 into habitat-sh:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants