Update bootstrap script in light of installer refactorings #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
The recent refactoring of our installation logic (#3344) inadvertently broke our bootstrap installation logic. Apparently, the earlier logic pulled dependent hart files from the same directory as the hart file being installed. In the new logic, it does not do this, but pulls everything from Builder through the artifact cache. The solution here is simply to place all the artifacts into the cache before installing the desired packages, just as we do with the public signing keys. True, we end up with some additional packages in our artifact cache, but that's fine. Besides, once we implement #3499, we can even clean those up. Fixes #3591 Signed-off-by: Christopher Maier <cmaier@chef.io>
christophermaier
force-pushed
the
cm/3591-fix-bootstrapping
branch
from
e7ab1b1
to
a206e27
Compare
mwrock
approved these changes
Oct 7, 2017
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
@thesentinels approve
|
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
christophermaier
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactoring of our installation logic (#3344) inadvertently
broke our bootstrap installation logic. Apparently, the earlier logic
pulled dependent hart files from the same directory as the hart file
being installed. In the new logic, it does not do this, but pulls
everything from Builder through the artifact cache.
The solution here is simply to place all the artifacts into the cache
before installing the desired packages, just as we do with the public
signing keys. True, we end up with some additional packages in our
artifact cache, but that's fine. Besides, once we implement #3499, we
can even clean those up.
Fixes #3591