add release notes step to release and make sure to include breaking changes #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
raskchanky
reviewed
Feb 21, 2018
RELEASE.md
Outdated
| * [BREAKING CHANGE] SOME BREAKING CHANGE | ||
| ``` | ||
|
|
||
| If you happen to be aware of features or bugs and feel there are user impacting words that need to be expressed. This is your opportunity to express them. Tasha will finalize and publish this PR after the release process is complete. |
There was a problem hiding this comment.
The first two sentences feel like one sentence that was accidentally split into two.
There was a problem hiding this comment.
hoo boy. I can't english.
|
One small grammar comment but otherwise looks great! |
|
|
…hanges Signed-off-by: mwrock <matt@mattwrock.com>
mwrock
force-pushed
the
break_release
branch
from
b30e55a
to
4c86a74
Compare
|
|
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mwrock matt@mattwrock.com