New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test habitat pipeline #6428
Conversation
Signed-off-by: Scott Hain <shain@chef.io>
Hello scotthain! Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
@@ -0,0 +1,3 @@ | |||
--- | |||
origin: scotthain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentionally set to my origin while testing so I don't pollute core with artifacts.
@@ -0,0 +1,3 @@ | |||
--- | |||
origin: scotthain | |||
smart_build: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes it "smart"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expeditor only rebuilds packages that have been modified if smart build is true. (This actually will have no effect currently because all this PR does is create the pipeline
@@ -44,3 +44,4 @@ pipelines: | |||
description: Deploy the website | |||
definition: .expeditor/website.pipeline.yml | |||
trigger: pull_request | |||
- habitat/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this maps to build.habitat.yml
, yeah? If so, why the inversion in the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - that's the default translation: https://expeditor.chef.io/docs/integrations/buildkite/#default-definition-values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context: habitat
is the type of pipeline and build
is the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obvious fix; these changes are the result of automation not creative thinking.
Signed-off-by: Scott Hain shain@chef.io