Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test habitat pipeline #6428

Merged
merged 1 commit into from Apr 15, 2019
Merged

Add test habitat pipeline #6428

merged 1 commit into from Apr 15, 2019

Conversation

scotthain
Copy link
Contributor

Signed-off-by: Scott Hain shain@chef.io

Signed-off-by: Scott Hain <shain@chef.io>
@chef-expeditor
Copy link
Contributor

Hello scotthain! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@@ -0,0 +1,3 @@
---
origin: scotthain
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentionally set to my origin while testing so I don't pollute core with artifacts.

@@ -0,0 +1,3 @@
---
origin: scotthain
smart_build: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes it "smart"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expeditor only rebuilds packages that have been modified if smart build is true. (This actually will have no effect currently because all this PR does is create the pipeline

@@ -44,3 +44,4 @@ pipelines:
description: Deploy the website
definition: .expeditor/website.pipeline.yml
trigger: pull_request
- habitat/build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this maps to build.habitat.yml, yeah? If so, why the inversion in the name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More context: habitat is the type of pipeline and build is the name.

Copy link
Contributor

@christophermaier christophermaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-35255394

@scotthain scotthain merged commit d9ea379 into master Apr 15, 2019
chef-ci added a commit that referenced this pull request Apr 15, 2019
Obvious fix; these changes are the result of automation not creative thinking.
@scotthain scotthain deleted the shain/build_hab branch May 7, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants