Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
adds working code and test for altering a package name to make it val… #6524
Since this has come up in a couple of comments on the code, I thought I would make a general comment here.
I chose to make a very small, easily testable function for formatting the resource name as a deliberate design decision.
I chose not to add it into the larger "new_from_cli_matches" intentionally. The "new_from_cli_matches" method has no current test coverage (the existing tests are all for the "generate" method). The "new_from_cli_matches" method needs a major refactor to make it straightforward to test. I've chosen not to take on that refactor at this time due to the amount of priorities we already have on our plate.
What I did choose to do was to start laying out the groundwork for a larger refactor and move us to more testable, modularized code by creating a new method that could easily be tested.