Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubernetes and helm exporter docs to include information about license acceptance #6573

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

nellshamrell
Copy link
Contributor

Signed-off-by: Nell Shamrell nellshamrell@gmail.com

@chef-expeditor
Copy link
Contributor

Hello nellshamrell! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@nellshamrell
Copy link
Contributor Author

@habitat-sh/docs-team

Copy link
Contributor

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits. See suggestions.

Copy link
Contributor

@christophermaier christophermaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with @kagarmoe's suggestions

@nellshamrell
Copy link
Contributor Author

Implemented @kagarmoe's suggestions!

nellshamrell and others added 3 commits June 3, 2019 14:02
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Co-Authored-By: Kimberly Garmoe <kgarmoe@chef.io>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Co-Authored-By: Kimberly Garmoe <kgarmoe@chef.io>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
@nellshamrell nellshamrell merged commit 17d0b43 into master Jun 6, 2019
chef-ci added a commit that referenced this pull request Jun 6, 2019
Obvious fix; these changes are the result of automation not creative thinking.
@christophermaier christophermaier deleted the nell-update-exporter-docs branch May 4, 2020 17:55
@christophermaier christophermaier added Documentation Flags an issue / PR for attention by the technical documentation team and removed A-documentation labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flags an issue / PR for attention by the technical documentation team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants