Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubernetes and helm exporter docs to include information about license acceptance #6573

Merged
merged 3 commits into from Jun 6, 2019

Conversation

@nellshamrell
Copy link
Contributor

commented May 17, 2019

Signed-off-by: Nell Shamrell nellshamrell@gmail.com

@nellshamrell nellshamrell requested a review from raskchanky as a code owner May 17, 2019

@chef-expeditor

This comment has been minimized.

Copy link

commented May 17, 2019

Hello nellshamrell! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@nellshamrell nellshamrell force-pushed the nell-update-exporter-docs branch from 5e80d2d to 93eaedf May 17, 2019

@nellshamrell

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

@kagarmoe
Copy link
Contributor

left a comment

Minor edits. See suggestions.

@christophermaier
Copy link
Contributor

left a comment

Looks good, with @kagarmoe's suggestions

@nellshamrell

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Implemented @kagarmoe's suggestions!

@nellshamrell nellshamrell force-pushed the nell-update-exporter-docs branch from 998ed99 to 4a6a099 Jun 3, 2019

@nellshamrell nellshamrell reopened this Jun 3, 2019

@nellshamrell nellshamrell force-pushed the nell-update-exporter-docs branch from 4a6a099 to 23a0a83 Jun 3, 2019

@nellshamrell nellshamrell reopened this Jun 3, 2019

nellshamrell and others added some commits May 17, 2019

update kubernetes and helm exporter docs
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Update www/source/partials/docs/_dev-pkgs-exports.html.md.erb
Co-Authored-By: Kimberly Garmoe <kgarmoe@chef.io>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Update www/source/partials/docs/_dev-pkgs-exports.html.md.erb
Co-Authored-By: Kimberly Garmoe <kgarmoe@chef.io>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>

@nellshamrell nellshamrell force-pushed the nell-update-exporter-docs branch from 23a0a83 to ee952a6 Jun 3, 2019

@nellshamrell nellshamrell merged commit 17d0b43 into master Jun 6, 2019

4 of 5 checks passed

buildkite/habitat-sh-habitat-master-verify Build #2130 passed and blocked (14 seconds)
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-website Build #2306 passed and blocked (13 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

chef-ci added a commit that referenced this pull request Jun 6, 2019

Update CHANGELOG.md with details from pull request #6573
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.