Ignore 'release' component of version if downloading from packages.chef.io #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ef.io Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
smacfarlane
requested review from
chefsalim,
christophermaier,
eeyun and
raskchanky
as code owners
Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
christophermaier
approved these changes
Jan 13, 2020
mwrock
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7253
For install
.tar.gz/.zipfiles hosted on packages.chef.io, we no longer use thereleaseportion of our fully qualified identifier in the filename or path. Since there is only ever oneversionas part of our new release process, we can safely ignore the release portion if the user specifies-vin the format ofversion/release.For Linux, if a release is specified it must still be valid, due to how we how we only use the packages.chef.io download to bootstrap and fetch the appropriate
.hartfrom Builder to install.version/releaseis still supported by our packages hosted in Bintray, so this change preserves the behavior for versions <= 0.88.0Signed-off-by: Scott Macfarlane smacfarlane@chef.io