[REFACTOR] Remove some lifetimes to simplify Docker exporter #7660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophermaier
force-pushed
the
cm/remove-lifetime-parameters
branch
from
d95d5f1
to
8917f77
Compare
These lifetime parameters were added to allow us to hold onto `str` references from our Clap `ArgMatches`. However, this ends up implicitly coupling all of our types to choices made by our CLI library. Also, there's no real benefit to not allocating a few extra Strings in a short-lived CLI application like this, so there's no reason to carry around the extra cognitive overhead. Signed-off-by: Christopher Maier <cmaier@chef.io>
christophermaier
force-pushed
the
cm/remove-lifetime-parameters
branch
from
8917f77
to
c86a835
Compare
mwrock
approved these changes
May 2, 2020
davidMcneil
approved these changes
May 4, 2020
Signed-off-by: Christopher Maier <cmaier@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lifetime parameters were added to allow us to hold onto
strreferences from our Clap
ArgMatches. However, this ends upimplicitly coupling all of our types to choices made by our CLI
library. Also, there's no real benefit to not allocating a few extra
Strings in a short-lived CLI application like this, so there's no
reason to carry around the extra cognitive overhead.
Signed-off-by: Christopher Maier cmaier@chef.io