Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supervisor config doc #7675

Merged
merged 6 commits into from
May 19, 2020
Merged

supervisor config doc #7675

merged 6 commits into from
May 19, 2020

Conversation

kagarmoe
Copy link
Contributor

@kagarmoe kagarmoe commented May 7, 2020 •
edited
Loading

Signed-off-by: kagarmoe kgarmoe@chef.io

  • Adds Supervisor Config section to reference doc
  • Adds entry to nav
  • Adds video to doc

(The site takes a long time to load locally)

2020-05-08_13-16-00 (1)

supervisor config doc
37572f1 
Signed-off-by: kagarmoe <kgarmoe@chef.io>
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented May 7, 2020

Hello kagarmoe! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

kagarmoe added 2 commits May 7, 2020 10:29
Group supervisor content
0488b3f 
Signed-off-by: kagarmoe <kgarmoe@chef.io>
adds video & nav
cea3229 
Signed-off-by: kagarmoe <kgarmoe@chef.io>
@kagarmoe kagarmoe marked this pull request as ready for review May 8, 2020 20:22
@kagarmoe kagarmoe requested a review from davidMcneil May 8, 2020 20:35
@kagarmoe kagarmoe self-assigned this May 9, 2020
@davidMcneil
Add config file default values
9a826a0 
Signed-off-by: David McNeil <mcneil.david2@gmail.com>
davidMcneil
davidMcneil approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@davidMcneil davidMcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There are maybe a few minor edits.

kagarmoe added 2 commits May 15, 2020 11:28
incorporates feedback
0748818 
Signed-off-by: kagarmoe <kgarmoe@chef.io>
Merge branch 'kg/new-config-file' of https://github.com/habitat-sh/ha…
46f5e02 
…bitat into kg/new-config-file
@kagarmoe kagarmoe merged commit dfb1353 into master May 19, 2020
@chef-expeditor chef-expeditor bot deleted the kg/new-config-file branch May 19, 2020 17:41
@christophermaier christophermaier added Documentation Flags an issue / PR for attention by the technical documentation team and removed A-documentation labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidMcneil davidMcneil davidMcneil approved these changes

@IanMadd IanMadd Awaiting requested review from IanMadd

@mjingle mjingle Awaiting requested review from mjingle

Assignees

@kagarmoe kagarmoe

Labels
Documentation Flags an issue / PR for attention by the technical documentation team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kagarmoe @davidMcneil @christophermaier