Use docker executor for kernel2 verify #7707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
smacfarlane
requested review from
christophermaier and
davidMcneil
as code owners
Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
christophermaier
suggested changes
May 21, 2020
| @@ -571,7 +571,7 @@ steps: | |||
| - .expeditor/scripts/verify/build_package.sh test-services/test-probe | |||
| expeditor: | |||
| executor: | |||
| linux: | |||
| docker: | |||
There was a problem hiding this comment.
I think the env block needs to be pulled down to an environment block under docker
There was a problem hiding this comment.
Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel2 verify steps mutate the CI host by installing the kernel2 hab cli, so we should use disposable infrastructure for these steps.
Signed-off-by: Scott Macfarlane smacfarlane@chef.io