[REFACTOR] Store service spec in Service struct #7752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than storing every individual component of a `ServiceSpec` inside a `Service` instance, we'll simply store a copy of the whole spec itself. Not only will this help clean up and streamline the `Service` struct, it should make it easier to update service configuration on-the-fly in the future by swapping in a new `ServiceSpec`. Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
This was only ever used for serialization purposes. Whether or not that serialization is truly necessary, we leave for another time. For now, access it from the inner spec. Signed-off-by: Christopher Maier <cmaier@chef.io>
Not clear exactly how useful this is to keep around, but at the very least, it doesn't need to be public. Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Signed-off-by: Christopher Maier <cmaier@chef.io>
Also, rename `to_spec` to just `spec`, since it's not a consuming operation. Signed-off-by: Christopher Maier <cmaier@chef.io>
christophermaier
force-pushed
the
cm/service-config-update
branch
from
cc997ce
to
19dcfdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary refactoring in service of #7635.
Rather than storing every individual component of a
ServiceSpecinside aServiceinstance, we'll simply store a copy of the whole spec itself.Not only will this help clean up and streamline the
Servicestruct, it should make it easier to update service configuration on-the-fly in the future by swapping in a newServiceSpec.Each commit deals with a small isolated aspect of this change (e.g., on field per commit) in order to ease the review burden.