Fix windows 7 support #8714
Merged
Fix windows 7 support #8714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The version of the "ipc-channel" crate is frozen at 0.15.0 to avoid the usage of the "GetOverlappedResultEx" system call, which was introduced in version 0.16.0. * An error type wrapper named "IPCError" is created around "ipc_channel::ipc::IpcError" because it does not implement the "std::error::Error" trait, which is required to use it with the "#[from]" attribute of the "thiserror" crate's "Error" derive macro. It is important to note that these changes should ideally be reverted once support for Windows 7 is discontinued around January 2024. This will allow for the usage of the "GetOverlappedResultEx" system call and the "ipc_channel::ipc::IpcError" trait. More information about "GetOverlappedResultEx" can be found at the following link: https://learn.microsoft.com/en-us/windows/win32/api/ioapiset/nf-ioapiset-getoverlappedresultex And the information about the commit that introduced the change can be found at: servo/ipc-channel@eb08381 Signed-off-by: Johny Jose <johny.jose@progress.com>
👷 Deploy Preview for chef-habitat processing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Habitat supervisor crashes on Windows 7. The crash arose from the usage of the "GetOverlappedResultEx" system call which is unsupported prior to Windows 8. This call is made by newer versions of the "ipc-channel" crate that is used in Habitat for Inter Process Communcation between the Launcher and Supervisor. As a result of this bug the Habitat Supervisor and Launcher would crash when they tried to communicate between themselves.
It is important to note that these changes should ideally be reverted once support for Windows 7 is discontinued around January 2024. This will allow for the usage of the "GetOverlappedResultEx" system call and the "ipc_channel::ipc::IpcError" trait. More information about "GetOverlappedResultEx" can be found at the following link: https://learn.microsoft.com/en-us/windows/win32/api/ioapiset/nf-ioapiset-getoverlappedresultex And the information about the commit that introduced the change can be found at: servo/ipc-channel@eb08381
Signed-off-by: Johny Jose johny.jose@progress.com