Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEF-3310: Ensure hab pkg install verifies all deps are installed #9082

Merged
merged 4 commits into from Nov 29, 2023

Conversation

atrniv
Copy link
Contributor

@atrniv atrniv commented Nov 15, 2023

This PR fixes a bug that causes Habitat to ignore missing tdeps during package installation if the parent package is already installed

Copy link

netlify bot commented Nov 15, 2023

👷 Deploy Preview for chef-habitat processing.

Name Link
🔨 Latest commit 08dee2e
🔍 Latest deploy log https://app.netlify.com/sites/chef-habitat/deploys/65671176de6a840008207e8a

Copy link
Contributor

@mwrock mwrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works as advertised. I think we should add an e2e test for this.

@mwrock
Copy link
Contributor

mwrock commented Nov 28, 2023

@atrniv if you rebase this, it should get pas the mac and audit failures.

Signed-off-by: Johny Jose <johny.jose@progress.com>
Signed-off-by: Johny Jose <johny.jose@progress.com>
Signed-off-by: Johny Jose <johny.jose@progress.com>
Signed-off-by: Johny Jose <johny.jose@progress.com>
@atrniv atrniv merged commit ac661df into main Nov 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants