Updates for Gitlab and misc README update #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskchanky
reviewed
Apr 3, 2018
README.md
Outdated
|
|
||
| Since substantial storage may be required for holding packages, you may need to create a mount point for the package directory. The packages are stored at the following location: `/hab/svc/builder-api/data` | ||
|
|
||
| It is recommended that you create a mount at `/hab` and point it to your external storage. |
There was a problem hiding this comment.
Is it worth wording this so that it's optional? If someone wants to mount their entire disk at /, everything will still work, provided they have enough disk space. This makes it sound like they need to have external storage, and a separate file system mount at /hab, which isn't strictly required.
There was a problem hiding this comment.
Good point - will update wording.
|
One minor comment, but otherwise looks good. |
Signed-off-by: Salim Alam <salam@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to config for Gitlab support, and a few updates to the README.
Signed-off-by: Salim Alam salam@chef.io