Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source service proxy settings from the current environment, check for… #3

Merged
merged 1 commit into from Feb 9, 2018
Merged

Source service proxy settings from the current environment, check for… #3

merged 1 commit into from Feb 9, 2018

Conversation

predominant
Copy link
Collaborator

… existence of curl before install

Signed-off-by: Graham Weldon graham@grahamweldon.com

Notes:

  • Check for curl before executing curl for hab install
  • Pull proxy configuration from the environment the script was run. I think this makes sense to do by default, and is a nice convenience to have it injected into the service definition when its required.

The proxy injection might need a more elegant solution? Not sure.

… existence of curl before install

Signed-off-by: Graham Weldon <graham@grahamweldon.com>
Copy link
Contributor

@elliott-davis elliott-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elliott-davis elliott-davis merged commit 03661d0 into habitat-sh:master Feb 9, 2018
@elliott-davis elliott-davis deleted the predominant/proxy-curl branch February 9, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants