Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/64 collection functions #109

Merged
merged 9 commits into from
Jan 24, 2022
Merged

Feat/64 collection functions #109

merged 9 commits into from
Jan 24, 2022

Conversation

eruizalo
Copy link
Collaborator

No description provided.

@eruizalo eruizalo added the enhancement New feature or request label Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021 •
edited

Codecov Report

Merging #109 (0d7e928) into main (dc2cab0) will increase coverage by 0.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   94.99%   95.93%   +0.94%     
==========================================
  Files          41       42       +1     
  Lines         698      786      +88     
  Branches        8       10       +2     
==========================================
+ Hits          663      754      +91     
+ Misses         35       32       -3
Impacted Files Coverage Δ
core/src/main/scala/doric/sem/AggregationOps.scala 75.00% <ø> (ø)
...ore/src/main/scala/doric/syntax/ArrayColumns.scala 100.00% <100.00%> (+12.00%) ⬆️
...re/src/main/scala/doric/syntax/BinaryColumns.scala 100.00% <100.00%> (ø)
core/src/main/scala/doric/syntax/ColGetters.scala 86.36% <100.00%> (+1.36%) ⬆️
...re/src/main/scala/doric/syntax/CommonColumns.scala 100.00% <100.00%> (ø)
core/src/main/scala/doric/syntax/MapColumns.scala 100.00% <100.00%> (ø)
...e/src/main/scala/doric/syntax/NumericColumns.scala 100.00% <100.00%> (ø)
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <100.00%> (ø)
core/src/main/scala/doric/syntax/package.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2cab0...0d7e928. Read the comment docs.

alfonsorr
alfonsorr requested changes Nov 21, 2021
View reviewed changes
core/src/main/scala/doric/syntax/CommonColumns.scala Outdated Show resolved Hide resolved
core/src/main/scala/doric/syntax/MapColumns.scala Outdated Show resolved Hide resolved
core/src/main/scala/doric/syntax/package.scala Outdated Show resolved Hide resolved
core/src/test/scala/doric/Equalities.scala Outdated Show resolved Hide resolved
core/src/test/scala/doric/TypedColumnTest.scala Outdated Show resolved Hide resolved
@eruizalo eruizalo linked an issue Nov 23, 2021 that may be closed by this pull request
Collection functions #64
Closed
74 tasks
@eruizalo eruizalo mentioned this pull request Jan 3, 2022
Open
@eruizalo eruizalo marked this pull request as ready for review January 23, 2022 16:09
@eruizalo eruizalo added the documentation Improvements or additions to documentation label Jan 23, 2022
@eruizalo eruizalo merged commit 75f91dd into hablapps:main Jan 24, 2022
@eruizalo eruizalo deleted the feat/64-collection-functions branch January 24, 2022 21:13
@eruizalo eruizalo mentioned this pull request Apr 20, 2022
Closed
74 tasks
@eruizalo eruizalo mentioned this pull request Jun 24, 2022
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsorr alfonsorr alfonsorr approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection functions
2 participants
@eruizalo @alfonsorr