Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused dependencies to be able to port doric to scala 2.11 #204

Merged

Conversation

alfonsorr
Copy link
Member

@alfonsorr alfonsorr commented Apr 10, 2022

Delete unused dependencies to be able to port doric to scala 2.11

Description

Deleted unused spark daria, and newtype that it doesn't have a 2.11 version

Related Issue

#205

Motivation and Context

Make possible to build doric for scala 2.11

How Has This Been Tested?

Against latest version of spark and waiting for the CI flow

  • This pull request contains appropriate tests?

@alfonsorr alfonsorr requested a review from a team as a code owner April 10, 2022 11:56
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #204 (49c5724) into main (390968c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          49       49           
  Lines         798      798           
  Branches       12       11    -1     
=======================================
  Hits          766      766           
  Misses         32       32           
Flag Coverage Δ
spark-3.0.x 94.82% <ø> (ø)
spark-3.1.x 95.97% <ø> (ø)
spark-3.2.x 95.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/main/scala/doric/CName.scala 100.00% <ø> (ø)
core/src/main/scala/doric/doric.scala 90.91% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 390968c...49c5724. Read the comment docs.

@alfonsorr alfonsorr mentioned this pull request Apr 10, 2022
5 tasks
@alfonsorr alfonsorr added this to the Doric for scala 2.11 milestone Apr 10, 2022
@alfonsorr alfonsorr requested a review from eruizalo April 10, 2022 12:07
@eruizalo eruizalo added dependencies Pull requests that update a dependency file breaking 💣 Breaking changes labels Apr 11, 2022
@alfonsorr alfonsorr merged commit 5159ac7 into hablapps:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking 💣 Breaking changes dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants